Skip to content

feat(TMF-2182): add docker file path in deploy#12

Merged
muhammad-tahir-nawaz merged 1 commit intomainfrom
feat/tmf-2193-add-docker-file-path
Apr 22, 2026
Merged

feat(TMF-2182): add docker file path in deploy#12
muhammad-tahir-nawaz merged 1 commit intomainfrom
feat/tmf-2193-add-docker-file-path

Conversation

@AnasAhmedTMF
Copy link
Copy Markdown
Contributor

@AnasAhmedTMF AnasAhmedTMF commented Apr 21, 2026

Summary

Added a new dockerfile_path input to the reusable deployment workflow. It accepts a custom path to the Dockerfile and defaults to Dockerfile (current behavior). The value is passed to docker/build-push-action via the file field, combined with docker_context to form the full path.

Why

Some services use non-standard Dockerfile locations or names (e.g., ims-event-processor/Dockerfile, ims-incident-manager/Dockerfile). Without this input, callers had no way to specify an alternate Dockerfile.

QA Report

  • No QA report required

Integration Tests

  • No integration tests required

Added

Edited

Dependencies

Copilot AI review requested due to automatic review settings April 21, 2026 11:46
@AnasAhmedTMF AnasAhmedTMF deployed to development April 21, 2026 11:46 — with GitHub Actions Active
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 21, 2026

Trivy Scan Results

Vulnerabilities Found


Report Summary

┌────────┬──────┬─────────────────┬─────────┐
│ Target │ Type │ Vulnerabilities │ Secrets │
├────────┼──────┼─────────────────┼─────────┤
│   -    │  -   │        -        │    -    │
└────────┴──────┴─────────────────┴─────────┘
Legend:
- '-': Not scanned
- '0': Clean (no security findings detected)

Copilot AI reviewed Apr 21, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new reusable-workflow input to support building Docker images from non-standard Dockerfile locations, while preserving the current default behavior.

Changes:

  • Introduced dockerfile_path as a workflow_call input (default: Dockerfile).
  • Passed the resolved Dockerfile path into docker/build-push-action via the file parameter, joined with docker_context.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

muhammad-tahir-nawaz
muhammad-tahir-nawaz approved these changes Apr 22, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@muhammad-tahir-nawaz muhammad-tahir-nawaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@muhammad-tahir-nawaz muhammad-tahir-nawaz merged commit 9e0e62f into main Apr 22, 2026
7 checks passed
@muhammad-tahir-nawaz muhammad-tahir-nawaz deleted the feat/tmf-2193-add-docker-file-path branch April 22, 2026 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@muhammad-tahir-nawaz muhammad-tahir-nawaz muhammad-tahir-nawaz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AnasAhmedTMF @muhammad-tahir-nawaz